Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/halufot routes better indicator #266

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

ArkadiK94
Copy link
Collaborator

Description

Temp solution in front-end for issue #176 , pls, don't close the issue there is a better solution to implement in back-end

Why: the user could see that there is a difference between two routes with same origin and destination
How: sorting the routes and indicate the "halufa" number beside the route title

screenshots

Recording.2023-12-01.193018.mp4
Recording.2023-12-01.192850.mp4

Why: the user could see that there is a difference between two routes with same fromRoute and toRoute
How: sorting the routes and indicate the halufa number baside the route title
Why: the user could see that there is a difference between two routes with same origin and destination
How: sorting the routes and indicate the halufa number beside the route title
@ArkadiK94 ArkadiK94 requested a review from NoamGaash as a code owner December 1, 2023 17:33
@ArkadiK94 ArkadiK94 changed the title Feat/halufot routes Feat/halufot routes better display Dec 1, 2023
@ArkadiK94 ArkadiK94 changed the title Feat/halufot routes better display Feat/halufot routes better indicator Dec 1, 2023
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@NoamGaash NoamGaash merged commit 8e3c2ca into hasadna:main Dec 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants